Subject: [i2rs] Benjamin Kaduk's No Objection on draft-ietf-i2rs-rib-data-model-10: (with COMMENT)

From: Benjamin Kaduk <[email-masked]>
Date: Tue, 03 Apr 2018 13:53:23 -0700

Benjamin Kaduk has entered the following ballot position for
draft-ietf-i2rs-rib-data-model-10: No Objection

When responding, please keep the subject line intact and reply to all
email addresses included in the To and CC lines. (Feel free to cut this
introductory paragraph, however.)

Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
for more information about IESG DISCUSS and COMMENT positions.

The document, along with other ballot positions, can be found here:
https://datatracker.ietf.org/doc/draft-ietf-i2rs-rib-data-model/

----------------------------------------------------------------------
COMMENT:
----------------------------------------------------------------------

I agree with Alissa's comment.

A couple nits:

In Section 2.6:
    Nexthops can be fully resolved or an unresolved.
I don't think the "an" is needed.

In the module itself:
   typedef nexthop-lb-weight-definition {
     type uint8 {
       range "1..99";
     }
     description
       "Nexthop-lb-weight is used for load-balancing.
        Each list member MUST be assigned a weight
        between 1 and 99. The weight determines the
        proportion of traffic to be sent over a nexthop
        used for forwarding as a ratio of the weight of
        this nexthop divided by the weights of all the

"sum of the weights", presumably.

        nexthops of this route that are used for forwarding.
        To perform equal load-balancing, one MAY specify
        a weight of 0 for all the member nexthops.  The
        value 0 is reserved for equal load-balancing
        and if applied, MUST be applied to all member nexthops.";
   }

Also, there's a mismatch between the MUST (1-99) and MAY (0).