Subject: few quick comments on the snapshot of draft-ietf-netconf-notifications

From: Li Yan <[email-masked]>
Date: Tue, 10 Jul 2007 10:24:05 +0800

Hi,
I have a few comments on this revision of the draft.

o  Named profile has been removed from the draft, but there are some remains of 'profile' still in the text.
   For example:
   sec 2.1.1
   Negative Response:
     ... if the name of a non-existent profile or stream is provided.
   sec 4
   <xs:element name="create-subscription"
     ...     
            <xs:documentation>
                ... It takes as argument the name of the notification stream
                and filter or profile information. 
            </xs:documentation>
     ...
   </xs:element>

o  sec 3.4
   <xs:element name="name" type="xs:string"/>
   should be
   <xs:element name="name" type="ncEvent:streamNameType"/>

o  sec 3.2.3 says: A NETCONF server implementation supporting the notification
   capability must support the "NETCONF" notification event stream.
   MUST the "NETCONF" notification event stream be present in the <eventStreams> element?
   If so, the 'minOccurs' of <stream> element should be 1 instead of 0.

o  sec 4
   Since the named profile was removed from the XSD for event notifications, the <xs:choice> element is not needed.

o  sec 5.2
   The 2nd example is wrong. The filtering criteria evaluation is not consistent with the XPATH expression in the <filter> element, and the namespace prefix is omitted.
   The XPath filter should be:
   <netconf:rpc message-id="101"
           xmlns:netconf="urn:ietf:params:xml:ns:netconf:base:1.0">
     <create-subscription
        xmlns="urn:ietf:params:netconf:capability:notification:1.0">
          <filter netconf:type="xpath"
                  xmlns:ex="http://example.com/event/1.0"
             select="/ex:event[
                (ex:eventClass='state' or ex:eventClass='config') and
                ((ex:eventClass='fault' and ex:severity='critical') or
                 (ex:eventClass='fault' and ex:severity='major') or
                 (ex:eventClass='fault' and ex:severity='minor') or
                 (ex:eventClass='fault' and ex:card='Ethernet0'))]"/>
    </create-subscription>
  </netconf:rpc>