Subject: [Netconf] Another comments on draft-ietf-netconf-subscribed-notifications-12

From: "Zhengguangying (Walker)" <[email-masked]>
Date: Thu, 14 Jun 2018 13:00:17 +0000

Hi Eric, Alex,

     In draft-ietf-netconf-subscribed-notifications-12  section "4.  Data Model",  the leafref to filters identifier was defined as a datatype as " typedef stream-filter-ref " , and this detatype are used in "configured-subscription" and " establish-subscription ".
     The issue is, when one does not support "/filters/" and use deviation file to deviate it as "not-supported", the target YANG file will have error when checking with yang tools, it lead to must support  "/filters/", I think it may not good to have this limit.
    
    One suggestion is not define the leaf ref to filter as a datatype, but use leafref directly when use " leafref " , what's your opinion?

Thanks 
Walker (Guangying)

PS:
Error: the node 'filters' from module 'ietf-subscribed-notifications' is not found
    
  typedef stream-filter-ref {
    type leafref {
      path "/sn:filters/sn:stream-filter/sn:identifier";
    }
    description
      "This type is used to reference an event stream filter.";
  }

  T 

rpcs:
    +---x establish-subscription
    |  +---w input
    |  |  +---w encoding?            encoding
    |  |  +---w (target)
    |  |  |  +--:(event-stream)
    |  |  |     +---w stream               stream
    |  |  |     +---w replay-start-time?   yang:date-and-time {replay}?
    |  |  +---w (applied-filter)
    |  |  |  +--:(by-reference)
    |  |  |  |  +---w filter-ref           filter-ref
    |  |  |  +--:(within-subscription)
    |  |  |     +---w (filter-type)?
    |  |  |        +--:(event-filter)
    |  |  |           +---w event-filter-type    event-filter-type
    |  |  |           +---w event-filter         <anyxml>
    |  |  +---w stop-time?           yang:date-and-time

+--rw subscription-config {configured-subscriptions}?
    |  +--rw subscription* [identifier]
    |     +--rw identifier           subscription-id
    |     +--rw encoding?            encoding
    |     +--rw (target)
    |     |  +--:(event-stream)
    |     |     +--rw stream               stream
    |     +--rw (applied-filter)
    |     |  +--:(by-reference)
    |     |  |  +--rw filter-ref           filter-ref
    |     |  +--:(within-subscription)
    |     |     +--rw (filter-type)?
    |     |        +--:(event-filter)
    |     |           +--rw event-filter-type    event-filter-type
    |     |           +--rw event-filter         <anyxml>
    |     +--rw stop-time?           yang:date-and-time
    |     +--rw receivers