Subject: Re: [netconf] Éric Vyncke's No Objection on draft-ietf-netconf-yang-push-22: (with COMMENT)

From: "Reshad Rahman (rrahman)" <[email-masked]>
Date: Tue, 30 Apr 2019 17:06:00 +0000

On 2019-04-30, 12:50 PM, "netconf on behalf of Eric Voit (evoit)" <[email-masked] on behalf of [email-masked]> wrote:

    > From: Alexander Clemm, April 30, 2019 12:33 PM
    > 
    > Hello Eric,
    > 
    > Thank you for your review!  Replies inline, <ALEX>
    > 
    > --- Alex
    > 
    > -----Original Message-----
    > From: Eric Vyncke (evyncke) <[email-masked]>
    > Sent: Monday, April 29, 2019 6:21 AM
    > To: The IESG <[email-masked]>
    > Cc: [email-masked]; [email-masked];
    > [email-masked]; [email-masked]
    > Subject: Re: Éric Vyncke's No Objection on draft-ietf-netconf-yang-push-22:
    > (with COMMENT)
    > 
    > Please ignore my comment C3, my bad...
    > 
    > -éric
    > 
    > On 29/04/2019, 15:12, "iesg on behalf of Éric Vyncke via Datatracker" <iesg-
    > [email-masked] on behalf of [email-masked]> wrote:
    > 
    >     Éric Vyncke has entered the following ballot position for
    >     draft-ietf-netconf-yang-push-22: No Objection
    > 
    >     When responding, please keep the subject line intact and reply to all
    >     email addresses included in the To and CC lines. (Feel free to cut this
    >     introductory paragraph, however.)
    > 
    > 
    >     Please refer to https://www.ietf.org/iesg/statement/discuss-criteria.html
    >     for more information about IESG DISCUSS and COMMENT positions.
    > 
    > 
    >     The document, along with other ballot positions, can be found here:
    >     https://datatracker.ietf.org/doc/draft-ietf-netconf-yang-push/
    > 
    > 
    > 
    >     ----------------------------------------------------------------------
    >     COMMENT:
    >     ----------------------------------------------------------------------
    > 
    >     Getting a streaming telemetry for changes in datastore appears quite useful.
    > 
    >     Please note that I did not review in depth after the section 4.
    > 
    >     Comments
    >     --------
    > 
    >     C1) Out of curiosity, it is surprising for a netconf wg document to have 7
    >     errors indicated by the YANG validator. Are they real errors or is the `pyang`
    >     validator incorrect or missing references?
    > 
    > <ALEX> There is a bug in the validator, which has been encountered for a while
    > and which Eric can explain.
    > </ALEX>
    
    The YANG validator errors are due to a solved bug in yanglint.   
    
    As Kent discusses in his "draft-ietf-netconf-subscribed-notifications" shepherd writeup, the errors clear with new versions of yanglint.
    https://datatracker.ietf.org/doc/draft-ietf-netconf-subscribed-notifications/shepherdwriteup/ 
    
       [SHEPHERD] `pyang` and `yanglint` were used to validate the YANG module 
       defined in this document.  Note that Datatracker shows YANG validation 
       errors, but the module validates fine on my machine (I'm using yanglint
       0.16.110, whereas DataTracker is using yanglint 0.14.80).
    
    Eric

It was fixed in 0.16.59
https://tools.ietf.org/tools/ietfdb/ticket/2667

Regards,
Reshad.