Subject: [ntpwg] [Technical Errata Reported] RFC5905 (3127)

From: RFC Errata System <[email-masked]>
Date: Fri, 17 Feb 2012 15:10:14 -0800 (PST)

The following errata report has been submitted for RFC5905,
"Network Time Protocol Version 4: Protocol and Algorithms Specification".

--------------------------------------
You may review the report below and at:
http://www.rfc-editor.org/errata_search.php?rfc=5905&eid=3127

--------------------------------------
Type: Technical
Reported by: Richard Walters <[email-masked]>

Section: A.5.5.1

Original Text
-------------
                /*

                 * Scan the chime list from lowest to highest to find

                 * the lower endpoint.

                 */

                found = 0;

                chime = 0;

                for (i = 0; i < n; i++) {

                        chime -= s.m[i].type;

                        if (chime >= n - found) {

                                low = s.m[i].edge;

                                break;

                        }

                        if (s.m[i].type == 0)

                                found++;

                }

                /*

                 * Scan the chime list from highest to lowest to find

                 * the upper endpoint.

                 */

                chime = 0;

                for (i = n - 1; i >= 0; i--) {

                        chime += s.m[i].type;

                        if (chime >= n - found) {

                                high = s.m[i].edge;

                                break;

                        }

                        if (s.m[i].type == 0)

                                found++;

                }

Corrected Text
--------------
                /*

                 * Scan the chime list from lowest to highest to find

                 * the lower endpoint.

                 */

                found = 0;

                chime = 0;

                for (i = 0; i < n; i++) {

                        chime -= s.m[i].type;

                        if (chime >= n - allow) {

                                low = s.m[i].edge;

                                break;

                        }

                        if (s.m[i].type == 0)

                                found++;

                }

                /*

                 * Scan the chime list from highest to lowest to find

                 * the upper endpoint.

                 */

                chime = 0;

                for (i = n - 1; i >= 0; i--) {

                        chime += s.m[i].type;

                        if (chime >= n - allow) {

                                high = s.m[i].edge;

                                break;

                        }

                        if (s.m[i].type == 0)

                                found++;

                }

Notes
-----
In both scans (lowest to highest, and highest to lowest)

chime >= n - found

needs to be:

chime >= n - allow

Instructions:
-------------
This errata is currently posted as "Reported". If necessary, please
use "Reply All" to discuss whether it should be verified or
rejected. When a decision is reached, the verifying party (IESG)
can log in to change the status and edit the report, if necessary. 

--------------------------------------
RFC5905 (draft-ietf-ntp-ntpv4-proto-13)
--------------------------------------
Title               : Network Time Protocol Version 4: Protocol and Algorithms Specification
Publication Date    : June 2010
Author(s)           : D. Mills, J. Martin, Ed., J. Burbank, W. Kasch
Category            : PROPOSED STANDARD
Source              : Network Time Protocol
Area                : Internet
Stream              : IETF
Verifying Party     : IESG
_______________________________________________
ntpwg mailing list
[email-masked]
http://lists.ntp.org/listinfo/ntpwg